Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, files are filtered from
pytestArgsbefore test discovery is run. This is unexpected for a user and could lead to issues:Given a file tree and
pytestArgstests/helpers/test_c.pywould be filtered and only tests inside oftests/dirwould be discovered.In large projects it's possible that different test subfolders require different dependencies via
conftest.py. Not all of them might be installed. If the desire was to only discover tests intests/dir/test_b.py, having that argument filtered would mean that discovery is run from root and thus allconftest.pyfiles are loaded. If the test is inside a subfolder, it's possible to work around it by removing the filename. However that doesn't work for tests inside the root test directory.Closes: #18562