Skip to content

Capture telemetry for usage of the setting autocomplete.addBrackets #1846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 3 commits into from
Jun 5, 2018
Merged

Capture telemetry for usage of the setting autocomplete.addBrackets #1846

DonJayamanne merged 3 commits into from
Jun 5, 2018

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Jun 2, 2018 •
edited
Loading

Fixes #1770
Fixes #1766

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)

@codecov
Copy link

codecov bot commented Jun 3, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@85e0400). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #1846   +/-   ##
========================================
  Coverage          ?   74.5%           
========================================
  Files             ?     282           
  Lines             ?   13260           
  Branches          ?    2378           
========================================
  Hits              ?    9880           
  Misses            ?    3250           
  Partials          ?     130
Impacted Files Coverage Δ
src/client/common/configSettings.ts 88.43% <100%> (ø)
src/client/telemetry/constants.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85e0400...dbd0d97. Read the comment docs.

@DonJayamanne DonJayamanne deleted the issue1770AddBrackets branch June 4, 2018 22:51
@DonJayamanne DonJayamanne restored the issue1770AddBrackets branch June 4, 2018 22:51
@DonJayamanne DonJayamanne reopened this Jun 5, 2018
@DonJayamanne DonJayamanne merged commit 9427d72 into microsoft:master Jun 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MikhailArkhipov MikhailArkhipov MikhailArkhipov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Telemetry to determine usage of addBrackets Capture telemetry to track usage of formatOnType

2 participants

@DonJayamanne @MikhailArkhipov