Skip to content

Add path mappings for remote debugging when attaching to the localhost #1830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 1 commit into from
Jun 5, 2018
Merged

Add path mappings for remote debugging when attaching to the localhost #1830

DonJayamanne merged 1 commit into from
Jun 5, 2018

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Jun 1, 2018

Fixes #1829

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@DonJayamanne DonJayamanne mentioned this pull request Jun 1, 2018
Merged
@DonJayamanne
Copy link
Author

DonJayamanne commented Jun 1, 2018

@brettcannon Would be good if we can get this PR merged (experimental debugger fix)

@codecov
Copy link

codecov bot commented Jun 2, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5fa57f8). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1830   +/-   ##
=========================================
  Coverage          ?   74.04%           
=========================================
  Files             ?      282           
  Lines             ?    13146           
  Branches          ?     2360           
=========================================
  Hits              ?     9734           
  Misses            ?     3274           
  Partials          ?      138
Impacted Files Coverage Δ
...lient/debugger/configProviders/pythonV2Provider.ts 84.37% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5fa57f8...e2c72e5. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 33505d2 into microsoft:master Jun 5, 2018
@DonJayamanne DonJayamanne deleted the issue1829AttachLocalHost branch June 20, 2018 03:17
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MikhailArkhipov MikhailArkhipov MikhailArkhipov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

VS Code opens file in another tab on breakpoint hit in attach

2 participants

@DonJayamanne @MikhailArkhipov