Skip to content

Improve detection if '=' is in function or lambda arguments #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MikhailArkhipov merged 113 commits into from
Jun 1, 2018
Merged

Improve detection if '=' is in function or lambda arguments #1824

MikhailArkhipov merged 113 commits into from
Jun 1, 2018

Conversation

@MikhailArkhipov
Copy link

@MikhailArkhipov MikhailArkhipov commented May 31, 2018

Fixes #1787
Fixes #1796

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

MikhailArkhipov and others added 30 commits March 27, 2018 14:58
Undo changes
a764bc9
Test fixes
9d1b2cc
Increase timeout
a91291a
Remove double event listening
bf266af
Remove test
7bc6bd6
Revert "Remove test"
8ce8b48 
This reverts commit e240c3f.
Revert "Remove double event listening"
e3a549e 
This reverts commit af573be.
#1096 The if statement is automatically formatted incorrectly
92e8c1e
Merge fix
b540a1d
Add more tests
7b0573e
More tests
facb106
Typo
f113881
Test
3e76718
Also better handle multiline arguments
6e85dc6
@brettcannon
Add a couple missing periods
99e037c 
[skip ci]
Undo changes
3caeab7
Test fixes
eeb1f11
Increase timeout
f5f78c7
Remove double event listening
88744da
Remove test
65dde44
Revert "Remove test"
c513f71 
This reverts commit e240c3f.
Revert "Remove double event listening"
ccb3886 
This reverts commit af573be.
Merge fix
106f4db
Merge branch 'master' of https://github.com/MikhailArkhipov/vscode-py…
9e5cb43 
…thon
#1257 On type formatting errors for args and kwargs
e1da6a6
Handle f-strings
e78f0fb
Stop importing from test code
725cf71
#1308 Single line statements leading to an indentation on the next line
5cd6d45
#726 editing python after inline if statement invalid indent
27613db
Undo change
8061a20
Mikhail Arkhipov added 24 commits May 28, 2018 19:36
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
2edeb3c 
…nto analysis
Rename the engine
2fd5387
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
a06b993 
…nto analysis
Formatting 1
0190078
Add support for 'rf' strings
5b93e34
Add two spaces before comment per PEP
781e6b1
Fix @ operator spacing
e795309
Handle module and unary ops
d300d0c
Type hints
dd09087
Fix typo
46b6dfd
Trailing comma
cf264b8
Require space after if
3e341e9
underscore numbers
3788f1d
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
e5a588e 
…nto format
Update list of keywords
06e7140
Merge branch 'format' into nums
5f4eba4
Function arguments
82a5ac0
Function arguments
b354bbd
PR feedback
c597d82
Merge branch 'format' into nums
361e106
Merge branch 'nums' into fcall
a0d639a
Handle lambdas
633b423
Merge master
1bc81c2
News
dd2c441
@MikhailArkhipov
Copy link
Author

MikhailArkhipov commented Jun 1, 2018

@DonJayamanne - could you have a look since this is for May. Thanks

@MikhailArkhipov MikhailArkhipov merged commit d27f00c into microsoft:master Jun 1, 2018
@MikhailArkhipov MikhailArkhipov deleted the fcall branch June 7, 2018 16:35
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

formatOnType add unnecessary spaces in kwargs in split line function formatOnType strips spacing around = for comma-trailing statements

3 participants

@MikhailArkhipov @DonJayamanne @brettcannon