Skip to content

If executeInFileDir is true always cd before exec #17597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
karrtikr merged 3 commits into from
Oct 14, 2021
Merged

If executeInFileDir is true always cd before exec #17597

karrtikr merged 3 commits into from
Oct 14, 2021

Conversation

@acash715
Copy link

@acash715 acash715 commented Oct 1, 2021 •
edited by karrtikr
Loading

Closes #15181

@ghost
Copy link

ghost commented Oct 1, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

karrtikr
karrtikr reviewed Oct 1, 2021
View reviewed changes
Copy link

@karrtikr karrtikr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @acash715, thank you for your contribution. Please add a news entry thanking yourself. See news/README.md for instructions.

@karrtikr karrtikr changed the base branch from main to OSD October 1, 2021 23:13
karrtikr
karrtikr reviewed Oct 1, 2021
View reviewed changes
@karrtikr karrtikr self-requested a review October 1, 2021 23:45
@karrtikr karrtikr merged commit 71ba1c0 into microsoft:OSD Oct 14, 2021
@karrtikr karrtikr mentioned this pull request Oct 14, 2021
Closed
karrtikr pushed a commit to karrtikr/vscode-python that referenced this pull request Oct 14, 2021
@acash715
If executeInFileDir is true always cd before exec (microsoft#17597)
c78ca4a 
* If executeInFileDir is true always cd before exec

* Add news entry

* Update news/2 Fixes/15181.md

Co-authored-by: Kartik Raj <[email protected]>
@karrtikr karrtikr mentioned this pull request Oct 14, 2021
Merged
karrtikr pushed a commit that referenced this pull request Oct 14, 2021
@acash715
If executeInFileDir is true always cd before exec (#17597) (#17744)
94a6ba8 
* If executeInFileDir is true always cd before exec

* Add news entry

* Update news/2 Fixes/15181.md

Co-authored-by: Kartik Raj <[email protected]>

Co-authored-by: acash715 <[email protected]>
@karrtikr karrtikr mentioned this pull request Oct 21, 2021
Closed
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
@acash715 @wesm
If executeInFileDir is true always cd before exec (microsoft/vscode-p…
95c1a01 
…ython#17597) (microsoft/vscode-python#17744)

* If executeInFileDir is true always cd before exec

* Add news entry

* Update news/2 Fixes/15181.md

Co-authored-by: Kartik Raj <[email protected]>

Co-authored-by: acash715 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karrtikr karrtikr Awaiting requested review from karrtikr

Assignees

@karrtikr karrtikr

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

python.terminal.executeInFileDir

2 participants

@acash715 @karrtikr