Skip to content

Conversation

@thi-lehoangy
Copy link

@thi-lehoangy thi-lehoangy commented Oct 1, 2021

For #7793

@luabud
Copy link
Member

luabud commented Oct 1, 2021

@ghost
Copy link

ghost commented Oct 1, 2021

CLA assistant check
All CLA requirements met.

@karrtikr karrtikr self-requested a review October 1, 2021 19:34
@thi-lehoangy
Copy link
Author

@luabud Can you take a look to see if it works now? Thanks!

@karrtikr karrtikr added skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary labels Oct 1, 2021
@karrtikr karrtikr changed the title Issue 7793 solved, rewrite description for experiment enabling Improve setting description for enabling A/B tests Oct 1, 2021
@@ -0,0 +1 @@
Improve setting description for enabling A/B tests. (Thanks [Thi Le](https://github.com/thi-lee))
Copy link

@karrtikr karrtikr Oct 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move this to news/1 Enhancements instead of news/2 Fixes? Thanks for the PR!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@karthiknadig
Copy link
Member

@thi-lee I am basing this to OSD branch. Since we are preparing main for release.

@karrtikr karrtikr changed the base branch from main to OSD October 1, 2021 19:47
@luabud luabud merged commit 63428e3 into microsoft:OSD Oct 1, 2021
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Oct 4, 2021
* Issue 7793 solved, rewrite discription for experiment enabling

* added news entry

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* moved news entry from 2 Fixes to 1 Enhancement
karthiknadig added a commit that referenced this pull request Oct 4, 2021
* Add a quick note about limited support on the web

* Tweak the description for virtual workspaces support

Closes #17600

* Update to vscode-extension-telemetry 0.4.2 (#17608)

* Update to vscode-extension-telemetry 0.4.2

* Add news

* Update to latest version of Jedi LS (#17591)

* Update to latest version of Jedi LS

* Add news

* Release candidate (#17610)

* Update version

* Update change logs

* Update notice

* Update main branch version (#17611)

* Reworded message for A/B testing in the output channel as per issue #6352 (#17584)

* Reworded message for A/B testing

* Reworded message for A/B testing

* Create 6352.md

* Added replaceAll for string prototype & unit tests (#17582)

* Added replaceAll for string prototype & unit tests

* Create 15288.md

* Bug Fix: use replaceAll for replacing separators.

* Ran prettier on updated files.

Co-authored-by: Aliva Das <[email protected]>

* Issue #17019: Reword commands in Run/Debug button in editor title (#17592)

* Reword commands in Run/Reword commands in Run/Debug button in editor title button in editor title

* fixed verbage

* update the wording in news file.

* Update news/2 Fixes/17019.md

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>

* Update python version in brew command (#17593)

* Update python version in brew command

Previously brew command installed python version 2 (outdated). Now brew command will install python 3.

* Create 17590.md

* Rewording news file description

Co-authored-by: Karthik Nadig <[email protected]>

Co-authored-by: Karthik Nadig <[email protected]>

* Improve setting description for enabling A/B tests (#17585)

* Issue 7793 solved, rewrite discription for experiment enabling

* added news entry

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* moved news entry from 2 Fixes to 1 Enhancement

* Issue #17037: Update text for "entire workspace" when selecting or clearing interpreters  (#17588)

* update entire workspace text

* add news item

* add news item

Co-authored-by: Quynh <[email protected]>

Co-authored-by: Brett Cannon <[email protected]>
Co-authored-by: Kim-Adeline Miguel <[email protected]>
Co-authored-by: Vidushi Gupta <[email protected]>
Co-authored-by: Aliva Das <[email protected]>
Co-authored-by: Aliva Das <[email protected]>
Co-authored-by: Anna Arsentieva <[email protected]>
Co-authored-by: Carolinekung2 <[email protected]>
Co-authored-by: Thi Le <[email protected]>
Co-authored-by: Quynhd07 <[email protected]>
Co-authored-by: Quynh <[email protected]>
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Oct 13, 2021
* Issue 7793 solved, rewrite discription for experiment enabling

* added news entry

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* moved news entry from 2 Fixes to 1 Enhancement
karthiknadig pushed a commit that referenced this pull request Oct 13, 2021
* Issue 7793 solved, rewrite discription for experiment enabling

* added news entry

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* moved news entry from 2 Fixes to 1 Enhancement
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
…python#17585)

* Issue 7793 solved, rewrite discription for experiment enabling

* added news entry

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* Update news/2 Fixes/7793.md

* moved news entry from 2 Fixes to 1 Enhancement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip package*.json package.json and package-lock.json don't both need updating skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants