Skip to content

Fix diag messages for magics #17057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rchiodo merged 2 commits into from
Aug 20, 2021
Merged

Fix diag messages for magics #17057

rchiodo merged 2 commits into from
Aug 20, 2021

Conversation

@rchiodo
Copy link

@rchiodo rchiodo commented Aug 20, 2021 •
edited
Loading

@rchiodo rchiodo added no-changelog No news entry required skip tests Updates to tests unnecessary labels Aug 20, 2021
@rchiodo rchiodo requested a review from a team August 20, 2021 21:10
@rchiodo rchiodo removed the no-changelog No news entry required label Aug 20, 2021
@rchiodo rchiodo merged commit b34a35e into microsoft:main Aug 20, 2021
@robince robince mentioned this pull request Mar 3, 2022
Closed
2 tasks
@deepbIue
Copy link

deepbIue commented Jul 12, 2024

It appears that the implementation does not handle magic commands that are indented.
Example:

def a():
    pass

def b():
    #!%timeit a  # this does not work
    %timeit a  # this works but raises a syntax error

b()
#!%timeit a  # this works and does not raise a syntax error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

Assignees

@karthiknadig karthiknadig

Labels

skip tests Updates to tests unnecessary

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inside of a notebook, magic cells should not cause an error in pylance

3 participants

@rchiodo @deepbIue @karthiknadig