Skip to content

Conversation

@iChenLei
Copy link

@iChenLei iChenLei commented Jul 18, 2021

Closes #16765

2021-07-18 15 55 53

vscode-test be marked as deprecated on npmjs.org(yarnpkg.com), so just replace vscode-test with latest @vscode/test-electron for vscode-python's CI. cc @karrtikr @karthiknadig to fix #16765

@karthiknadig karthiknadig requested a review from kimadeline July 21, 2021 21:36
@kimadeline
Copy link

Thank you for your contribution @iChenLei!

Please create an issue for this PR and mark it as an enhancement, and add a news entry as well.

@iChenLei
Copy link
Author

@kimadeline Hi, I create issue (But i don't have premission to mark label) and news entry md file.

@kimadeline kimadeline added the skip tests Updates to tests unnecessary label Jul 23, 2021
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karrtikr karrtikr changed the title chore: replace deprecated vscode-test with @vscode/test-electron Replace deprecated vscode-test with @vscode/test-electron Jul 23, 2021
@karrtikr karrtikr merged commit b1dabce into microsoft:main Jul 23, 2021
@iChenLei iChenLei deleted the vscode-test-deprecated branch July 23, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip tests Updates to tests unnecessary

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace deprecated vscode-test with @vscode/test-electron

4 participants