Skip to content

Prefix display name with 'Python' only if not already prefixed #1652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 3 commits into from
May 11, 2018
Merged

Prefix display name with 'Python' only if not already prefixed #1652

DonJayamanne merged 3 commits into from
May 11, 2018

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented May 10, 2018

Fixes #1651

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented May 10, 2018 •
edited
Loading

Codecov Report

Merging #1652 into master will increase coverage by 6.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1652      +/-   ##
=========================================
+ Coverage   64.96%   71.3%   +6.34%     
=========================================
  Files         277     277              
  Lines       12985   12986       +1     
  Branches     2334    2335       +1     
=========================================
+ Hits         8436    9260     +824     
+ Misses       4542    3584     -958     
- Partials        7     142     +135
Impacted Files Coverage Δ
src/client/interpreter/locators/helpers.ts 88.88% <100%> (+0.65%) ⬆️
src/client/unittests/main.ts 50.75% <0%> (+1%) ⬆️
src/client/common/net/socket/SocketStream.ts 88.88% <0%> (+2.08%) ⬆️
src/client/debugger/Common/telemetry.ts 95.23% <0%> (+2.38%) ⬆️
src/client/common/variables/systemVariables.ts 88.13% <0%> (+3.38%) ⬆️
src/client/common/platform/registry.ts 36.17% <0%> (+4.25%) ⬆️
...c/client/debugger/DebugClients/nonDebugClientV2.ts 28.57% <0%> (+7.14%) ⬆️
src/client/common/idDispenser.ts 100% <0%> (+7.14%) ⬆️
src/client/common/application/documentManager.ts 55.55% <0%> (+7.4%) ⬆️
...sts/common/services/workspaceTestManagerService.ts 65% <0%> (+7.5%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3085cb1...18f408f. Read the comment docs.

@DonJayamanne DonJayamanne force-pushed the issueTODORemovePythonPrefixIfExists branch from 9db462a to 58894f3 Compare May 11, 2018 03:55
@DonJayamanne DonJayamanne merged commit 5171927 into microsoft:master May 11, 2018
@DonJayamanne DonJayamanne deleted the issueTODORemovePythonPrefixIfExists branch June 20, 2018 03:17
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MikhailArkhipov MikhailArkhipov MikhailArkhipov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix display name of interpreters to remove duplicate Python prefix

2 participants

@DonJayamanne @MikhailArkhipov