Lint files affected by the Jupyter work #16462
Conversation
kimadeline
added
no-changelog
| "eslint": "^7.2.0", | ||
| "eslint-config-airbnb": "^18.2.0", | ||
| "eslint-config-prettier": "^6.15.0", | ||
| "eslint-config-prettier": "^8.3.0", |
There was a problem hiding this comment.
Had to update it because ESLint and Prettier had conflicting formatting for React components, which exist in startPage.tsx. Turns out this caused many files to suddenly fail the linting check 😆
| onKeyPress={this.openBlankNotebook} | ||
| role="button" | ||
| tabIndex={0} |
| } | ||
|
|
||
| public openFolder = () => { | ||
| public openFolder = (): void => { |
There was a problem hiding this comment.
openFolder is defined as an arrow function expression, while openFileBrowser is a method on the class. I don't know why it was done that way, but I didn't want to touch it and risk breaking things. Will have to be revisited in #16453.
| } | ||
|
|
||
| private openBlankNotebook = () => { | ||
| private openBlankNotebook(): void { |
There was a problem hiding this comment.
These methods are private, while openFileBrowser, openFileBrowser and openWorkspace are public, despite nothing referencing them. I don't know why it was done that way, but I didn't want to touch it and risk breaking things. Will have to be revisited in #16453. (also undid my change from arrow function expression to method)
3 participants
Closes #16102 since it's the last PR directly related to it.
I tried fixing linting errors without modifying any functionality so as to not accidentally break what with the Jupyter extension expects, so I didn't change the start page too much. It will need to be revisited in #16453 anyway.
Windows venv test failures reported in #16454.
Smoke test failures handled in #16457.