-
Notifications
You must be signed in to change notification settings - Fork 1.3k
16368 Only show last file/folder names on nodes in test explorer #16369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16368 Only show last file/folder names on nodes in test explorer #16369
Conversation
karthiknadig
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Thanks for taking the time to update tests and linting.
|
Hi I'm struggling to get the failing tests to fail locally and I can't understand how to re-run the failing PR/CI checks on github - is there any guidance you can point me at other than the 'contributing' wiki? Thanks, Bob |
|
@bobwalker99 You many not have the permissions to run them. I will trigger a re-run. |
|
Thanks @karthiknadig, much appreciated. I think the failures highlighted by my change are partly due to this bit of code in the test setup: vscode-python/src/test/testing/nosetest/nosetest.disovery.test.ts Lines 96 to 99 in cd8f4d3
The test is creating hybrid posix / windows paths which accidentally worked before in the test, but wouldn't happen in real life. I'm not sure whether the right thing to do is to try to just change the test, or try to handle it in the discovery parsing code. Both are potentially problematic. It's also quite difficult to evaluate locally as I can't get the test grep to work to the point where I can just run this single test quickly and step though it, so I'm having to guess at it to a large extent. When I run the larger suite I get various other errors, including errors about missing All the best, |
paulacamargo25
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Job :)
|
@bobwalker99 You probably have to set This configuration below worked for me to narrow down to the nose test suite: {
"name": "Tests (Single Workspace, VS Code, *.test.ts)",
"type": "extensionHost",
"request": "launch",
"runtimeExecutable": "${execPath}",
"args": [
"${workspaceFolder}/src/test",
"--disable-extensions",
"--extensionDevelopmentPath=${workspaceFolder}",
"--extensionTestsPath=${workspaceFolder}/out/test"
],
"env": {
"VSC_PYTHON_CI_TEST_GREP": "Unit Tests - nose"
},
"stopOnEntry": false,
"sourceMaps": true,
"outFiles": ["${workspaceFolder}/out/**/*.js", "!${workspaceFolder}/**/node_modules**/*"],
"preLaunchTask": "Compile",
"skipFiles": ["<node_internals>/**"]
}, |
|
Can you rebase with the latest main? I can look into the tests and see what needs to be changed. |
…vscode-python into feature/bw-16368-nose-paths
Done, thanks @karthiknadig |
Also match on unmodified input to forgive hybrid separators scenario in Windows tests (thanks @karthiknadig) Co-authored-by: Karthik Nadig <[email protected]>
Fixes #16368