Add column offset to fix mypy linter pointing to wrong column number (off by one) #15505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthiknadig
requested changes
Feb 25, 2021
Member
karthiknadig
left a comment
karthiknadig
left a comment
There was a problem hiding this comment.
Thanks for the fix. Please add a news item, and don't forget to credit yourself for the fix.
|
|
karthiknadig
approved these changes
Feb 25, 2021
karrtikr
reviewed
Feb 25, 2021
karrtikr
left a comment
karrtikr
left a comment
There was a problem hiding this comment.
Thanks for the PR! Please edit the corresponding test,
to pass column offset as 1 in parseLine.
|
The tests are failing, you may need to adjust the expected output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14978
Before:
After:
