Skip to content

Add files to trigger extension #15486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brettcannon merged 3 commits into from
Feb 24, 2021
Merged

Add files to trigger extension #15486

brettcannon merged 3 commits into from
Feb 24, 2021

Conversation

@Soneji
Copy link

@Soneji Soneji commented Feb 23, 2021 •
edited by brettcannon
Loading

Closes #4765

@ghost
Copy link

ghost commented Feb 23, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@brettcannon brettcannon added the skip package*.json package.json and package-lock.json don't both need updating label Feb 23, 2021
brettcannon
brettcannon reviewed Feb 23, 2021
View reviewed changes
brettcannon
brettcannon suggested changes Feb 23, 2021
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need to simplify the news entry, otherwise LGTM!

karthiknadig
karthiknadig requested changes Feb 23, 2021
View reviewed changes
@karthiknadig karthiknadig mentioned this pull request Feb 23, 2021
Merged
@Soneji
Copy link
Author

Soneji commented Feb 24, 2021

Thanks for the help and reviews :)

@brettcannon brettcannon merged commit 2459093 into microsoft:main Feb 24, 2021
@Soneji Soneji deleted the python-related-files-trigger branch February 24, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

2 more reviewers

@brettcannon brettcannon brettcannon approved these changes

@kimadeline kimadeline kimadeline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kimadeline kimadeline

Labels

skip package*.json package.json and package-lock.json don't both need updating

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

If I have Python-related files in my workspace, automatically activate the extension

4 participants

@Soneji @brettcannon @karthiknadig @kimadeline