Skip to content

Conversation

@jakebailey
Copy link
Member

@jakebailey jakebailey commented Nov 18, 2020

Supersedes #14697 (@bschnurr is out and we want this in).

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@jakebailey jakebailey added the no-changelog No news entry required label Nov 18, 2020
@jakebailey jakebailey marked this pull request as ready for review November 18, 2020 20:08
@jakebailey jakebailey mentioned this pull request Nov 18, 2020
11 tasks
@jakebailey jakebailey marked this pull request as draft November 18, 2020 21:08
@jakebailey jakebailey marked this pull request as ready for review November 18, 2020 21:55
@jakebailey
Copy link
Member Author

OK, I'm an idiot and left a test.only in here, so the tests fail.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jakebailey jakebailey merged commit 3d61063 into microsoft:main Nov 19, 2020
@jakebailey jakebailey deleted the jedi-banner branch November 19, 2020 00:08
jakebailey added a commit to jakebailey/vscode-python that referenced this pull request Nov 19, 2020
karthiknadig pushed a commit to karthiknadig/vscode-python that referenced this pull request Nov 19, 2020
karthiknadig added a commit that referenced this pull request Nov 19, 2020
* Add new tryPylance banner experiments (#14759)

Co-authored-by: Bill Schnurr <[email protected]>

* Put linter prompt behind experiment (#14731)

* Add new linter prompt

* Tests

* Fix typos

* Show linter install message only once.

* Add more tests and news

* Updates for point release.

Co-authored-by: Jake Bailey <[email protected]>
Co-authored-by: Bill Schnurr <[email protected]>
karrtikr pushed a commit to karrtikr/vscode-python that referenced this pull request Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants