Skip to content

Conversation

@karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Nov 14, 2020

for #14760

@karthiknadig karthiknadig changed the title [WIP] - Put linter prompt behind experiment Put linter prompt behind experiment Nov 16, 2020
@karthiknadig karthiknadig marked this pull request as ready for review November 16, 2020 22:22
@karthiknadig karthiknadig added the no-changelog No news entry required label Nov 16, 2020
Copy link

@karrtikr karrtikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add a news entry regarding the experiment I think.

@karthiknadig karthiknadig removed the no-changelog No news entry required label Nov 18, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@karthiknadig karthiknadig merged commit 452ac16 into microsoft:main Nov 18, 2020
karthiknadig added a commit to karthiknadig/vscode-python that referenced this pull request Nov 19, 2020
* Add new linter prompt

* Tests

* Fix typos

* Show linter install message only once.

* Add more tests and news
karthiknadig added a commit that referenced this pull request Nov 19, 2020
* Add new tryPylance banner experiments (#14759)

Co-authored-by: Bill Schnurr <[email protected]>

* Put linter prompt behind experiment (#14731)

* Add new linter prompt

* Tests

* Fix typos

* Show linter install message only once.

* Add more tests and news

* Updates for point release.

Co-authored-by: Jake Bailey <[email protected]>
Co-authored-by: Bill Schnurr <[email protected]>
@karthiknadig karthiknadig deleted the linter1 branch December 10, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants