wip new jedi tryPylance banner #14697
Conversation
Codecov Report
|
| ShowBanner = 'TryPylanceBannerJedi' | ||
| } | ||
|
|
||
| /* |
There was a problem hiding this comment.
This file is basically the same as the previous tryPylance banner ProposePylanceBanner.ts
just the data and some of the logic have changed
| promptContent = await this.experiments.getExperimentValue<string>(TryPylance.jediPrompt1); | ||
| } else if (await this.experiments.inExperiment(TryPylance.jediPrompt2)) { | ||
| promptContent = await this.experiments.getExperimentValue<string>(TryPylance.jediPrompt2); | ||
| } |
There was a problem hiding this comment.
new way to check if we're in an experiment and also get the banner string
| if (lsType !== LanguageServerType.Jedi) { | ||
| return false; | ||
| } | ||
| return this.persistentState.createGlobalPersistentState<boolean>(ProposeLSStateKeys.ShowBanner, true).value; |
There was a problem hiding this comment.
I defined a new key but the string inside is different. I'll double check if i need to export it.
export enum ProposeLSStateKeys {
ShowBanner = 'TryPylanceBannerJedi'
}
| @inject(IExperimentService) experimentService: IExperimentService | ||
| @inject(IExperimentService) experimentService: IExperimentService, | ||
| @inject(IPythonExtensionBanner) | ||
| @named(BANNER_NAME_PROPOSE_LS_FOR_JEDI_USERS) |
bschnurr
force-pushed
the
jedi-tryplance
branch
from
45ac706 to
ee5d9f7
Compare
adding experimentName to old tryPlance test telemetry
|
Kudos, SonarCloud Quality Gate passed!
|
|
Closing in favor of #14759. |
4 participants
Todo:
For #
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).