Skip to content

Fixes multiple issues with formatting on type #1450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MikhailArkhipov merged 51 commits into from
Apr 23, 2018
Merged

Fixes multiple issues with formatting on type #1450

MikhailArkhipov merged 51 commits into from
Apr 23, 2018

Conversation

@MikhailArkhipov
Copy link

@MikhailArkhipov MikhailArkhipov commented Apr 20, 2018

Fixes #1354
Reflects changes to build on Linux

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

MikhailArkhipov and others added 30 commits March 27, 2018 14:58
Undo changes
a764bc9
Test fixes
9d1b2cc
Increase timeout
a91291a
Remove double event listening
bf266af
Remove test
7bc6bd6
Revert "Remove test"
8ce8b48 
This reverts commit e240c3f.
Revert "Remove double event listening"
e3a549e 
This reverts commit af573be.
#1096 The if statement is automatically formatted incorrectly
92e8c1e
Merge fix
b540a1d
Add more tests
7b0573e
More tests
facb106
Typo
f113881
Test
3e76718
Also better handle multiline arguments
6e85dc6
@brettcannon
Add a couple missing periods
99e037c 
[skip ci]
Undo changes
3caeab7
Test fixes
eeb1f11
Increase timeout
f5f78c7
Remove double event listening
88744da
Remove test
65dde44
Revert "Remove test"
c513f71 
This reverts commit e240c3f.
Revert "Remove double event listening"
ccb3886 
This reverts commit af573be.
Merge fix
106f4db
Merge branch 'master' of https://github.com/MikhailArkhipov/vscode-py…
9e5cb43 
…thon
#1257 On type formatting errors for args and kwargs
e1da6a6
Handle f-strings
e78f0fb
Stop importing from test code
725cf71
#1308 Single line statements leading to an indentation on the next line
5cd6d45
#726 editing python after inline if statement invalid indent
27613db
Undo change
8061a20
MikhailArkhipov and others added 21 commits April 5, 2018 15:59
Move constant
17dc292
Harden LS startup error checks
65964b9
#1364 Intellisense doesn't work after specific const string
4bf5a4c
Merge branch 'master' of https://github.com/Microsoft/vscode-python
6f7212c
Telemetry for the analysis enging
ddbd295
Merge branch 'master' of https://github.com/Microsoft/vscode-python
ffd1d3f
PR feedback
d4afb6c
Fix typo
12186b8
Test baseline update
ca90529
Jedi 0.12
a7267b5
Priority to goto_defition
cfee109
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
1285789 
…nto jedi
News
d1ff1d9
Replace unzip
1bd1651
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
a69b6fd 
…nto jedi
Linux flavors + test
f916ace
Grammar check
28ca25f
Grammar test
ad9a3c9
Test baselines
ff8dd35
Merge branch 'master' of https://github.com/Microsoft/vscode-python i…
26726f8 
…nto grammar
@brettcannon
Pin dependency
0b3f316 
[skip ci]
@MikhailArkhipov MikhailArkhipov merged commit db9f6cf into microsoft:master Apr 23, 2018
@brettcannon brettcannon mentioned this pull request Apr 23, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Validate editor.formatOnType validity using Python's test grammar

3 participants

@MikhailArkhipov @DonJayamanne @brettcannon