Skip to content

Set focus to the terminal upon creation of a terminal using the Create Terminal command #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 2 commits into from
Apr 20, 2018
Merged

Set focus to the terminal upon creation of a terminal using the Create Terminal command #1433

DonJayamanne merged 2 commits into from
Apr 20, 2018

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Apr 18, 2018

Fixes #1315

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Apr 18, 2018

Codecov Report

Merging #1433 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1433      +/-   ##
==========================================
+ Coverage    70.8%   70.82%   +0.02%     
==========================================
  Files         271      271              
  Lines       12519    12519              
  Branches     2224     2224              
==========================================
+ Hits         8864     8867       +3     
+ Misses       3512     3511       -1     
+ Partials      143      141       -2
Impacted Files Coverage Δ
src/client/common/terminal/types.ts 100% <ø> (ø) ⬆️
src/client/common/terminal/service.ts 100% <100%> (ø) ⬆️
src/client/providers/terminalProvider.ts 100% <100%> (ø) ⬆️
src/client/debugger/mainV2.ts 75% <0%> (-0.81%) ⬇️
src/client/debugger/PythonProcess.ts 47.91% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 759bbce...d40fa04. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 1465bda into microsoft:master Apr 20, 2018
@brettcannon brettcannon mentioned this pull request Apr 24, 2018
Closed
@DonJayamanne DonJayamanne deleted the issue1315FocusTerminal branch June 20, 2018 03:14
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MikhailArkhipov MikhailArkhipov MikhailArkhipov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cursor should be in the terminal after running the Create Terminal command

2 participants

@DonJayamanne @MikhailArkhipov