Skip to content

Capture and display errors returned by pipenv command #1430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 5 commits into from
Apr 18, 2018
Merged

Capture and display errors returned by pipenv command #1430

DonJayamanne merged 5 commits into from
Apr 18, 2018

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Apr 18, 2018

Fixes #1254
Fixes #1428

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@DonJayamanne DonJayamanne merged commit a6267b7 into microsoft:master Apr 18, 2018
@DonJayamanne DonJayamanne deleted the issue1254PipEnvErrors branch June 20, 2018 03:14
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MikhailArkhipov MikhailArkhipov MikhailArkhipov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Ensure current environment variables are passed into process invoked to get pipenv info Errors returned by pipenv command not logged

2 participants

@DonJayamanne @MikhailArkhipov