Skip to content

Conversation

@rchiodo
Copy link

@rchiodo rchiodo commented Oct 6, 2020

Noticed this extra branch in the pr-validation yaml. I'm hoping this gets the AZDO stuff to work again? Anyway I don't think we want this branch there.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

REmove missing branch? Might make it work again
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rchiodo rchiodo self-assigned this Oct 6, 2020
@rchiodo rchiodo added the no-changelog No news entry required label Oct 6, 2020
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@7049770). Click here to learn what that means.
The diff coverage is 64.31%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #14285   +/-   ##
=======================================
  Coverage        ?   59.91%           
=======================================
  Files           ?      709           
  Lines           ?    39334           
  Branches        ?     5698           
=======================================
  Hits            ?    23566           
  Misses          ?    14530           
  Partials        ?     1238           
Impacted Files Coverage Δ
src/client/activation/common/activatorBase.ts 14.41% <0.00%> (ø)
...rc/client/activation/jedi/multiplexingActivator.ts 17.74% <0.00%> (ø)
src/client/activation/node/languageServerProxy.ts 26.58% <0.00%> (ø)
src/client/activation/refCountedLanguageServer.ts 41.30% <0.00%> (ø)
src/client/activation/types.ts 100.00% <ø> (ø)
src/client/common/process/pythonDaemon.ts 14.28% <0.00%> (ø)
src/client/common/utils/localize.ts 96.24% <ø> (ø)
src/client/datascience/baseJupyterSession.ts 57.33% <ø> (ø)
.../datascience/interactive-common/interactiveBase.ts 5.78% <0.00%> (ø)
...ient/datascience/interactive-ipynb/nativeEditor.ts 7.78% <0.00%> (ø)
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7049770...e9e5584. Read the comment docs.

@rchiodo rchiodo merged commit fee7e74 into main Oct 7, 2020
@rchiodo rchiodo deleted the rchiodo-patch-1 branch October 7, 2020 00:13
DonJayamanne pushed a commit that referenced this pull request Oct 30, 2020
* Fix two problems with escaping (#14228)

* Remove unneeded cell keys when exporting (#14241)

* Remove transient output when exporting from the interactive window

* Add news entry

* Test was failing with true jupyter (#14261)

* Potential fix for ipywidget flakiness (#14281)

* Try running tests with space in root path (#14113)

* Add test with a space (only works on flake)

* Push to insiders.yml only

* Remove test that doesn't really do anything

* REmove unused bits

* Change path to have unicode too

* Get test to run

* Set root path differently

* Valid dir

* A different way

* Another way

* Try creating the directory first

* Another try

* Only one env

* Pass parameters correctly

* Try without unicode

* Set working directory directly on xvfb actions

* Working-directory not workingDirectory

* Cached ts files output

* Remove test with space branch for insiders

* Update vscode-python-pr-validation.yaml (#14285)

REmove missing branch? Might make it work again

* Get rid of AZDO yamls. Not used anymore

* Dont run on push (#14307)

* Fix random failures on functional tests (#14331)

* Splitting test log

* Fix problem with kernels ports being reused

* Make kernel launcher port round robin only for testing

* Make formatters change only apply during testing

* Add news entry

* Apply black formatting

* Code review feedback and skip flakey remote password test

* Another flakey test

* More CR feedback

* Missed a spot

* More of the functional tests are failing (#14346)

* Splitting test log

* Fix problem with kernels ports being reused

* Make kernel launcher port round robin only for testing

* Make formatters change only apply during testing

* Add news entry

* Apply black formatting

* Code review feedback and skip flakey remote password test

* Another flakey test

* More CR feedback

* Missed a spot

* Some more log parser changes and try to get interrupt to be less flakey

* Fix interrupt killing kernel and add more logging for export

* More logging

* See if updating fixes the problem

* Dont delete temp files

* Upload webview output to figure out trust failure

* Add name to step

* Try another way to upload

* Upload doesn't seem to work

* Try a different way to upload

* Try without webview logging as this makes the test pass

* Try fixing test another way. Any logging is making the test pass

* Compile error

* Add more logging to figure out why raw kernel did not start (#14374)

* Some more logging

* Some more logging

* Move PR changes into pr.yml

* Fix multiprocessing problems with setting __file__ (#14376)

* Fix multiprocessing problems with setting __file__

* Update news entry

* Problem with wait for idle not propagating outwards

* Fix unnecessary ask for python extension install

* Don't error on warning for kernel install
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants