Skip to content

Use an existing method to identify the active interpreter #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 3 commits into from
Mar 30, 2018
Merged

Use an existing method to identify the active interpreter #1215

DonJayamanne merged 3 commits into from
Mar 30, 2018

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Mar 27, 2018

Fixes #1015

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file (remember to thank yourself!)
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Mar 27, 2018 •
edited
Loading

Codecov Report

Merging #1215 into master will decrease coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1215      +/-   ##
==========================================
- Coverage   72.21%   72.03%   -0.19%     
==========================================
  Files         260      260              
  Lines       11933    11928       -5     
  Branches     2121     2119       -2     
==========================================
- Hits         8618     8592      -26     
- Misses       3188     3214      +26     
+ Partials      127      122       -5
Impacted Files Coverage Δ
src/client/interpreter/contracts.ts 100% <ø> (ø) ⬆️
src/client/common/installer/moduleInstaller.ts 48.14% <100%> (-2.7%) ⬇️
src/client/linters/errorHandlers/notInstalled.ts 33.33% <0%> (-61.12%) ⬇️
src/client/linters/errorHandlers/errorHandler.ts 77.77% <0%> (-22.23%) ⬇️
src/client/common/logger.ts 53.33% <0%> (-20.01%) ⬇️
src/client/common/application/applicationShell.ts 23.07% <0%> (-7.7%) ⬇️
src/client/common/installer/productInstaller.ts 60.31% <0%> (-4.24%) ⬇️
src/client/linters/baseLinter.ts 87.5% <0%> (-4.17%) ⬇️
...rc/client/debugger/PythonProcessCallbackHandler.ts 53.61% <0%> (+1.31%) ⬆️
src/client/debugger/PythonProcess.ts 48.75% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73bec31...25a00f3. Read the comment docs.

@DonJayamanne DonJayamanne changed the title Use an existing method to identify the active interpreter 1. Use an existing method to identify the active interpreter Mar 30, 2018
@DonJayamanne DonJayamanne changed the title 1. Use an existing method to identify the active interpreter Use an existing method to identify the active interpreter Mar 30, 2018
@DonJayamanne DonJayamanne merged commit ba9c2f6 into microsoft:master Mar 30, 2018
@DonJayamanne DonJayamanne deleted the issue1015UseActiveInterpreter branch June 20, 2018 03:19
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@brettcannon brettcannon brettcannon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Module installer is using the wrong pythonPath

2 participants

@DonJayamanne @brettcannon