Skip to content

Add support to read name of Pipfile from environment variable #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 2 commits into from
Mar 17, 2018
Merged

Add support to read name of Pipfile from environment variable #1092

DonJayamanne merged 2 commits into from
Mar 17, 2018

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Mar 16, 2018

Fixes #999

This pull request:

  • Has a title summarizes what is changing
  • Includes a news entry file
  • Has unit tests & code coverage is not adversely affected (within reason)
  • Works on all actively maintained versions of Python (e.g. Python 2.7 & the latest Python 3 release)
  • Works on Windows 10, macOS, and Linux (e.g. considered file system case-sensitivity)

@codecov
Copy link

codecov bot commented Mar 16, 2018 •
edited
Loading

Codecov Report

Merging #1092 into master will increase coverage by 0.12%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1092      +/-   ##
=========================================
+ Coverage   71.67%   71.8%   +0.12%     
=========================================
  Files         260     260              
  Lines       11877   11887      +10     
  Branches     2104    2106       +2     
=========================================
+ Hits         8513    8535      +22     
+ Misses       3239    3227      -12     
  Partials      125     125
Impacted Files Coverage Δ
...ent/interpreter/locators/services/pipEnvService.ts 94.73% <100%> (+26.65%) ⬆️
src/client/debugger/Main.ts 49.51% <0%> (-0.49%) ⬇️
src/client/debugger/Common/Utils.ts 44.26% <0%> (+3.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba97e02...f84b36f. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 487fc81 into microsoft:master Mar 17, 2018
@DonJayamanne DonJayamanne deleted the issue999 branch March 19, 2018 22:17
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@MikhailArkhipov MikhailArkhipov MikhailArkhipov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add support to read name of Pipfile from environment variable

2 participants

@DonJayamanne @MikhailArkhipov