Skip to content

Fixes issue that display incorrect interpreter briefly before updating it to the right value #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DonJayamanne merged 3 commits into from
Mar 15, 2018
Merged

Fixes issue that display incorrect interpreter briefly before updating it to the right value #1054

DonJayamanne merged 3 commits into from
Mar 15, 2018

Conversation

@DonJayamanne
Copy link

@DonJayamanne DonJayamanne commented Mar 13, 2018

Fixes #981

@codecov
Copy link

codecov bot commented Mar 13, 2018 •
edited
Loading

Codecov Report

Merging #1054 into master will decrease coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1054      +/-   ##
==========================================
- Coverage   64.17%   63.83%   -0.35%     
==========================================
  Files         259      260       +1     
  Lines       11838    12010     +172     
  Branches     2094     2133      +39     
==========================================
+ Hits         7597     7666      +69     
- Misses       4233     4335     +102     
- Partials        8        9       +1
Impacted Files Coverage Δ
src/client/common/configSettings.ts 87.26% <100%> (ø) ⬆️
src/client/linters/prospector.ts 15.78% <0%> (-63.16%) ⬇️
src/client/common/configSettingMonitor.ts 42.59% <0%> (-42.6%) ⬇️
src/client/common/logger.ts 33.33% <0%> (-20%) ⬇️
src/client/linters/pydocstyle.ts 90.24% <0%> (-4.88%) ⬇️
src/client/interpreter/interpreterService.ts 76.34% <0%> (-3.23%) ⬇️
src/client/linters/linterManager.ts 82.6% <0%> (-2.9%) ⬇️
src/client/linters/baseLinter.ts 85.41% <0%> (-2.09%) ⬇️
src/client/linters/linterInfo.ts 100% <0%> (ø) ⬆️
src/client/formatters/helper.ts 100% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503ffb5...2840367. Read the comment docs.

@DonJayamanne DonJayamanne merged commit 822cd7a into microsoft:master Mar 15, 2018
@DonJayamanne DonJayamanne deleted the issue981 branch March 15, 2018 16:52
@lock lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@brettcannon brettcannon brettcannon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Interpreter information displayed in status bar is incorrect

2 participants

@DonJayamanne @brettcannon