Skip to content

python.linting.flake8CategorySeverity.F should default to "Warning", not "Error" #815

@danvk

Description

@danvk

(Moving over from microsoft/vscode#43851)

With flake8, the "F*" issues are labeled as errors by default (https://code.visualstudio.com/docs/python/linting#_flake8).

I think this comes from a misunderstanding of what "F" (vs. "W" or "E") means in this context. For flake8, it means that these are issues flagged by pyflakes, rather than that these are fatal errors. See http://flake8.pycqa.org/en/latest/glossary.html#term-class

The upshot is that issues like unused imports are flagged as errors by default with pyflake, rather than as warnings. They should be warnings:

{
  "python.linting.flake8CategorySeverity.F": "Warning"
}
  • VSCode Version: Version 1.19.2 (1.19.2)
  • OS Version: macOS Sierra 10.12.6 (16G29)

Metadata

Metadata

Labels

area-lintingbugIssue identified by VS Code Team member as probable bug

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions