forked from DonJayamanne/pythonVSCode
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Closed
Labels
area-editor-*User-facing catch-allUser-facing catch-alldebtCovers everything internal: CI, testing, refactoring of the codebase, etc.Covers everything internal: CI, testing, refactoring of the codebase, etc.verifiedVerification succeededVerification succeeded
Milestone
Description
In #16417 we made a small change to the start page code (see this comment thread), but a general review of startPage.ts and startPage.tsx might be needed.
A couple of things I noticed here and there, but by no means an exhaustive list:
- Why are
openFolderandopenWorkspacedefined differently in
https://github.com/microsoft/vscode-python/blob/main/src/startPage-ui/startPage/startPage.tsx#L170-L180 - Why are some of the
open____methods public, and others are private? - When having the start page open, clicking on "Open a Folder" or the folder icon or the "Open a Folder or Workspace" header doesn't seem to do anything
Do this work as part of #16678
IanMatthewHuff
Metadata
Metadata
Assignees
Labels
area-editor-*User-facing catch-allUser-facing catch-alldebtCovers everything internal: CI, testing, refactoring of the codebase, etc.Covers everything internal: CI, testing, refactoring of the codebase, etc.verifiedVerification succeededVerification succeeded