Skip to content

Remove terminal detectors except the one which uses the VSCode API #16023

New issue
New issue
Closed as not planned
Bug
Closed as not planned
Remove terminal detectors except the one which uses the VSCode API#16023
Bug
Labels
area-terminalbugIssue identified by VS Code Team member as probable buggood first issueneeds PRReady to be worked on
@kimadeline

Description

@kimadeline
kimadeline
opened on Apr 22, 2021

There's a VS Code API that was added a while ago which we could take advantage of to figure out which shell would be launched by opening a terminal #6050 and the upstream VS Code issue microsoft/vscode#75091.

The recommendation in the vscode-python issue was to drop all of our existing shell detection mechanisms in favour of the VS Code API one, however we still have them:

vscode-python/src/client/common/serviceRegistry.ts

Lines 201 to 204 in 8661ba7

serviceManager.addSingleton<IShellDetector>(IShellDetector, TerminalNameShellDetector);
serviceManager.addSingleton<IShellDetector>(IShellDetector, SettingsShellDetector);
serviceManager.addSingleton<IShellDetector>(IShellDetector, UserEnvironmentShellDetector);
serviceManager.addSingleton<IShellDetector>(IShellDetector, VSCEnvironmentShellDetector);

➡️ Are they still necessary, all of them?

Second, shells and terminal profiles are going to change (see terminal tabs).

➡️ What does that mean for us?

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-terminalbugIssue identified by VS Code Team member as probable buggood first issueneeds PRReady to be worked on

    Type

    Bug

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions