Skip to content

Space in extension path: Multiworkspace failures #14165

@rchiodo

Description

@rchiodo
  1. Module Installer
    Validate pip install arguments without a resource:

    Invalid command sent to terminal for installation.

    • expected - actual

    -"/home/runner/work/vscode-python/vscode-python/path with spaces/pythonFiles/pyvsc-run-isolated.py" pip install -U xyz --user
    +/home/runner/work/vscode-python/vscode-python/path with spaces/pythonFiles/pyvsc-run-isolated.py pip install -U xyz --user

    at Context. (out/test/common/moduleInstaller.test.js:356:47)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)

  2. Module Installer
    Validate Conda install arguments without a resource:

    Invalid command sent to terminal for installation.

    • expected - actual

    -"/home/runner/work/vscode-python/vscode-python/path with spaces/pythonFiles/pyvsc-run-isolated.py" pip install -U xyz
    +/home/runner/work/vscode-python/vscode-python/path with spaces/pythonFiles/pyvsc-run-isolated.py pip install -U xyz

    at Context. (out/test/common/moduleInstaller.test.js:379:47)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)

  3. Module Installer
    Validate pip install arguments with a resource:

    Invalid command sent to terminal for installation.

    • expected - actual

    -"/home/runner/work/vscode-python/vscode-python/path with spaces/pythonFiles/pyvsc-run-isolated.py" pip install -U xyz --user
    +/home/runner/work/vscode-python/vscode-python/path with spaces/pythonFiles/pyvsc-run-isolated.py pip install -U xyz --user

    at Context. (out/test/common/moduleInstaller.test.js:356:47)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)

  4. Module Installer
    Validate Conda install arguments with a resource:

    Invalid command sent to terminal for installation.

    • expected - actual

    -"/home/runner/work/vscode-python/vscode-python/path with spaces/pythonFiles/pyvsc-run-isolated.py" pip install -U xyz
    +/home/runner/work/vscode-python/vscode-python/path with spaces/pythonFiles/pyvsc-run-isolated.py pip install -U xyz

    at Context. (out/test/common/moduleInstaller.test.js:379:47)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)

  5. Multiroot Linting
    Enabling Pylint in root and also in Workspace, should return errors:

    AssertionError [ERR_ASSERTION]: No errors returned by linter

    • expected - actual

    -false
    +true

    at testLinterInWorkspaceFolder (out/test/linters/lint.multiroot.test.js:67:16)
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at runTest (out/test/linters/lint.multiroot.test.js:94:9)
    at Context. (out/test/linters/lint.multiroot.test.js:70:9)

  6. Multiroot Linting
    Disabling Pylint in root and enabling in Workspace, should return errors:

    AssertionError [ERR_ASSERTION]: No errors returned by linter

    • expected - actual

    -false
    +true

    at testLinterInWorkspaceFolder (out/test/linters/lint.multiroot.test.js:67:16)
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at runTest (out/test/linters/lint.multiroot.test.js:94:9)
    at Context. (out/test/linters/lint.multiroot.test.js:76:9)

  7. Multiroot Linting
    Enabling Flake8 in root and also in Workspace, should return errors:

    AssertionError [ERR_ASSERTION]: No errors returned by linter

    • expected - actual

    -false
    +true

    at testLinterInWorkspaceFolder (out/test/linters/lint.multiroot.test.js:67:16)
    at runTest (out/test/linters/lint.multiroot.test.js:94:9)
    at Context. (out/test/linters/lint.multiroot.test.js:79:9)

  8. Multiroot Linting
    Disabling Flake8 in root and enabling in Workspace, should return errors:

    AssertionError [ERR_ASSERTION]: No errors returned by linter

    • expected - actual

    -false
    +true

    at testLinterInWorkspaceFolder (out/test/linters/lint.multiroot.test.js:67:16)
    at runTest (out/test/linters/lint.multiroot.test.js:94:9)
    at Context. (out/test/linters/lint.multiroot.test.js:85:9)

  9. Unit Tests - debugging
    Debugger should start (nosetest):

    Incorrect number of test files

    • expected - actual

    -0
    +2

    at testStartingDebugger (out/test/testing/debugger.test.js:95:23)
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at Context. (out/test/testing/debugger.test.js:126:9)

  10. Unit Tests - debugging
    Debugger should stop when user invokes a test discovery (nosetest):

    Incorrect number of test files

    • expected - actual

    -0
    +2

    at testStoppingDebugger (out/test/testing/debugger.test.js:132:23)
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at Context. (out/test/testing/debugger.test.js:154:9)

  11. Unit Tests - debugging
    Debugger should not stop when test discovery is invoked automatically by extension (nosetest):

    Incorrect number of test files

    • expected - actual

    -0
    +2

    at testDebuggerWhenRediscoveringTests (out/test/testing/debugger.test.js:160:23)
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at Context. (out/test/testing/debugger.test.js:190:9)

  12. Unit Tests - nose - discovery against actual python process
    Discover Tests (single test file):

    AssertionError [ERR_ASSERTION]: Incorrect number of test files

    • expected - actual

    -0
    +2

    at Context. (out/test/testing/nosetest/nosetest.test.js:63:16)
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:94:5)

  13. Unit Tests re-discovery
    Re-discover tests (nosetest):

    Incorrect number of test files

    • expected - actual

    -0
    +2

    at discoverUnitTests (out/test/testing/rediscover.test.js:61:23)
    at runMicrotasks ()
    at processTicksAndRejections (internal/process/task_queues.js:94:5)
    at Context. (out/test/testing/red

Steps to repro:

  1. clone into path with a space
  2. Run multiWorkspace test

Or if that doesn't work, use a github action as done in this PR
#14113

Metadata

Metadata

Assignees

No one assigned

    Labels

    area-internalLabel for non-user facing issuesbugIssue identified by VS Code Team member as probable bugimportantIssue identified as high-priority

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions