Fall back to getting checks without suite for enterprise#8442
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR attempts to fix issue #8378 where viewing PR descriptions in GitHub Enterprise with Data Residency results in "GraphQL error: Not Found" errors. The fix makes all Enterprise instances fall back to using a simplified GraphQL query (GetChecksWithoutSuite) that omits the checkSuite field.
Changes:
- Modified error handling in
getStatusChecks()to always use the fallback query for Enterprise instances
Comments suppressed due to low confidence (1)
src/github/githubRepository.ts:1671
- This fix may cause performance degradation for Enterprise instances. The GetChecksWithoutSuite query omits the checkSuite field, which means it doesn't return app information, workflow run details, and event data for CheckRuns (see lines 1097-1108 in queriesShared.gql). This information is used later in the code (lines 1702-1714) to populate workflow names and event details.
For Enterprise instances that do support the checkSuite field, this change forces them to always make incomplete queries, potentially degrading the user experience by losing this contextual information about their checks.
if (isSamlError(e) || this.remote.isEnterprise) {
chrmarti
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8378