Skip to content

Await makeNewIssueFile to fix Edit Description button race condition#8420

Merged
alexr00 merged 3 commits intomainfrom
copilot/fix-edit-description-button
Jan 26, 2026
Merged

Await makeNewIssueFile to fix Edit Description button race condition#8420
alexr00 merged 3 commits intomainfrom
copilot/fix-edit-description-button

Conversation

Copy link
Contributor

Copilot AI commented Jan 23, 2026 •
edited
Loading

Clicking "Edit Description" (pencil icon) in the "Create Issue From Selection" dialog closes the dialog without opening the issue editor. Race condition: makeNewIssueFile() wasn't awaited, so quickInput.hide() executed before the editor could open.

Changes

  • Add await to makeNewIssueFile() call in onDidTriggerButton handler
  • Add await to makeNewIssueFile() call in createIssue() for consistency
// Before
quickInput.onDidTriggerButton(async () => {
    this.makeNewIssueFile(document.uri, { title, body, assignees });
    quickInput.hide();  // Closes immediately
});

// After
quickInput.onDidTriggerButton(async () => {
    await this.makeNewIssueFile(document.uri, { title, body, assignees });
    quickInput.hide();  // Waits for editor to open
});
Original prompt

This section details on the original issue you should resolve

<issue_title>“Edit Description” button does nothing when using the Create Issue From Selection command</issue_title>
<issue_description>- Extension version: 0.122.1

  • VSCode Version: Code 1.106.2 (1e3c50d64110be466c0b4a45222e81d2c9352888, 2025-11-19T16:56:50.023Z)
  • OS: Windows_NT x64 10.0.26200

Steps to Reproduce:

  1. Highlight some code
  2. Ctrl+Shift+P to bring up Command Palette
  3. Select GitHub Issues: Create Issue From Selection
  4. Click “Edit Description” (pencil icon) in the dialogue box that opens
  5. Box closes and nothing happens

Workaround: Enter a title and press Enter to create the issue first, then go to the issue to edit details

System Info
Item Value
CPUs AMD Ryzen 7 5700G with Radeon Graphics (16 x 4400)
GPU Status 2d_canvas: enabled
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
trees_in_viz: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Load (avg) undefined
Memory (System) 31.80GB (15.79GB free)
Process Argv --open-url --crash-reporter-id 3503fce5-c328-4a8b-ae11-e8cc9ac95f7e -- vscode:extension/GitHub.vscode-pull-request-github
Screen Reader no
VM 0%

Comments on the Issue (you are @copilot in this section)

@alexr00 I'm not able to repro this issue. I see that a new issue editor shows: Image

Do you see any errors?</comment_new>
<comment_new>@alexr00
Huh thanks for the video. Can you please do the following:

  1. Repro the issue
  2. Share the output of GitHub Pull Request
  3. Open the dev tools (command "Developer: Toggle Developer Tools") and share the contents of the dev console</comment_new>

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix edit description button in create issue command Await makeNewIssueFile to fix Edit Description button race condition Jan 23, 2026
Copilot AI requested a review from alexr00 January 23, 2026 17:43
@alexr00 alexr00 marked this pull request as ready for review January 26, 2026 10:24
Copilot AI review requested due to automatic review settings January 26, 2026 10:24
@alexr00 alexr00 enabled auto-merge (squash) January 26, 2026 10:24
Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a race condition where clicking “Edit Description” in the Create Issue From Selection input box could close the dialog without opening the new-issue editor, by awaiting the async editor-opening path before hiding the QuickInput.

Changes:

  • await the makeNewIssueFile() call when handling the Edit Description button, so the editor opens before the dialog is hidden.
  • await the makeNewIssueFile() call in createIssue() for consistency with the async behavior of that helper.

@vs-code-engineering vs-code-engineering bot added this to the January 2026 milestone Jan 26, 2026
@alexr00 alexr00 merged commit 28b8b10 into main Jan 26, 2026
12 checks passed
@alexr00 alexr00 deleted the copilot/fix-edit-description-button branch January 26, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@chrmarti chrmarti chrmarti approved these changes

+1 more reviewer

@alexr00 alexr00 alexr00 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alexr00 alexr00

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

January 2026

Development

Successfully merging this pull request may close these issues.

“Edit Description” button does nothing when using the Create Issue From Selection command

4 participants

@chrmarti @alexr00