Skip to content

UI fixes for checks section#4059

Merged
alexr00 merged 8 commits into
microsoft:mainfrom
Thomas1664:ui-fix-checks
Oct 17, 2022
Merged

UI fixes for checks section#4059
alexr00 merged 8 commits into
microsoft:mainfrom
Thomas1664:ui-fix-checks

Conversation

@Thomas1664

@Thomas1664 Thomas1664 commented Oct 14, 2022

Copy link
Copy Markdown
Contributor
  • Make show/hide an actual button
  • Add spacing between check name and details

Before:

image

After:

image

@Thomas1664 Thomas1664 changed the title UI fixes for the checks section UI fixes for checks section Oct 14, 2022
@daviddossett
daviddossett self-requested a review October 14, 2022 22:52
@Thomas1664

Copy link
Copy Markdown
Contributor Author

Note that I reported the smaller ✔ on the wrapping check name as #4064

Comment thread webviews/components/merge.tsx Outdated

@alexr00 alexr00 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for the PR! Will merge after @daviddossett has also signed off.

@daviddossett daviddossett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alexr00 alexr00 added this to the October 2022 milestone Oct 17, 2022
@alexr00
alexr00 merged commit ea54232 into microsoft:main Oct 17, 2022
@Thomas1664
Thomas1664 deleted the ui-fix-checks branch October 17, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants