Adding fabric warning for dacpac dialog and small fix to styles#20599
Merged
allancascante merged 3 commits intomainfrom Nov 17, 2025
Merged
Adding fabric warning for dacpac dialog and small fix to styles#20599allancascante merged 3 commits intomainfrom
allancascante merged 3 commits intomainfrom
Conversation
This was
linked to
issues
Nov 15, 2025
PR Changes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20599 +/- ##
=======================================
Coverage 38.80% 38.81%
=======================================
Files 213 213
Lines 87245 87253 +8
Branches 19521 19521
=======================================
+ Hits 33858 33864 +6
- Misses 53139 53141 +2
Partials 248 248 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
allancascante
requested review from
Benjin,
aasimkhan30,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez,
manujoseph85 and
ssreerama
as code owners
allancascante
changed the title
aasimkhan30
reviewed
Nov 17, 2025
| /** | ||
| * Checks if a connection profile is connected to a Fabric server | ||
| */ | ||
| private isFabricConnection(profile: IConnectionDialogProfile): boolean { |
Contributor
There was a problem hiding this comment.
NIT. Maybe move this to general utils so we don't duplicate this.
aasimkhan30
approved these changes
Nov 17, 2025
lewis-sanchez
approved these changes
Nov 17, 2025
allancascante
added a commit
that referenced
this pull request
Nov 17, 2025
* adding fabric warning for dacpac dialog and small fix to styles * lint fixes * localization changes
5 tasks
kburtram
pushed a commit
that referenced
this pull request
Nov 17, 2025
#20604) * Follow up fixes after PR merge (#20519) - Added when clause to DacPac commands in command palette to respect mssql.experimentalFeaturesEnabled flag #20512 - Renamed DacPac commands to grouped naming convention (mssql.dacpacDialog.*) #20513 - Added OS-specific localization for "Reveal in Explorer" button (Windows/macOS/Linux) #20511 - Extracted Data-tier Applications documentation URL to constants - Updated application version validation to accept 2-part versions (e.g., 1.0) #20514 - Changed validation state to display warnings * Adding fabric warning for dacpac dialog and small fix to styles (#20599) * adding fabric warning for dacpac dialog and small fix to styles * lint fixes * localization changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dacpac deploy to new database and bacpac import to new database is not supported, adding message and UI changes to allow some partial support. Also fixed the layout to show scrollbars when the window is too small to fit the dialog.
On Deploy dacpac:
On import bacpac
This was reported as part of #20568 and #20567
Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines