Skip to content

[Port] Include preview dacpac dialog#20584

Merged
kburtram merged 4 commits intorelease/1.37from
port/allancascante/include_preview_dacpac_dialog
Nov 14, 2025
Merged

[Port] Include preview dacpac dialog#20584
kburtram merged 4 commits intorelease/1.37from
port/allancascante/include_preview_dacpac_dialog

Conversation

@allancascante
Copy link
Copy Markdown
Contributor

@allancascante allancascante commented Nov 14, 2025

Description

Fixes: #20578 original PR: #20581

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

- Added when clause to DacPac commands in command palette to respect mssql.experimentalFeaturesEnabled flag #20512 
- Renamed DacPac commands to grouped naming convention (mssql.dacpacDialog.*) #20513 
- Added OS-specific localization for "Reveal in Explorer" button (Windows/macOS/Linux) #20511 
- Extracted Data-tier Applications documentation URL to constants
- Updated application version validation to accept 2-part versions (e.g., 1.0) #20514 
- Changed validation state to display warnings
* adding preview to the dacpac dialog labels

* adding preview to the dacpac dialog labels
@kburtram kburtram merged commit 8388959 into release/1.37 Nov 14, 2025
3 checks passed
@kburtram kburtram deleted the port/allancascante/include_preview_dacpac_dialog branch November 14, 2025 01:04
@github-actions
Copy link
Copy Markdown

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 59.75% 59.75% ⚪ 0.00%
VSIX Size 5245 KB 5245 KB ⚪ 0 KB ( 0% )
Webview Bundle Size 5256 KB 5256 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/1.37@841bbfb). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/1.37   #20584   +/-   ##
===============================================
  Coverage                ?   38.94%           
===============================================
  Files                   ?      210           
  Lines                   ?    86809           
  Branches                ?    19437           
===============================================
  Hits                    ?    33806           
  Misses                  ?    52755           
  Partials                ?      248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants