Skip to content

[Port] Dacpac dialog telemetry updates#20544

Merged
kburtram merged 3 commits intorelease/1.37from
port/allancascante/dacpacTelemetryUpdates
Nov 12, 2025
Merged

[Port] Dacpac dialog telemetry updates#20544
kburtram merged 3 commits intorelease/1.37from
port/allancascante/dacpacTelemetryUpdates

Conversation

@allancascante
Copy link
Copy Markdown
Contributor

@allancascante allancascante commented Nov 12, 2025

Description

Fixes: #20516, Original PR #20540

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

- Added when clause to DacPac commands in command palette to respect mssql.experimentalFeaturesEnabled flag #20512 
- Renamed DacPac commands to grouped naming convention (mssql.dacpacDialog.*) #20513 
- Added OS-specific localization for "Reveal in Explorer" button (Windows/macOS/Linux) #20511 
- Extracted Data-tier Applications documentation URL to constants
- Updated application version validation to accept 2-part versions (e.g., 1.0) #20514 
- Changed validation state to display warnings
@kburtram kburtram merged commit 5fdafd5 into release/1.37 Nov 12, 2025
1 of 2 checks passed
@kburtram kburtram deleted the port/allancascante/dacpacTelemetryUpdates branch November 12, 2025 00:56
@github-actions
Copy link
Copy Markdown

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 59.67% 59.67% ⚪ 0.00%
VSIX Size 5238 KB 5238 KB ⚪ 0 KB ( 0% )
Webview Bundle Size 5256 KB 5256 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/1.37@9726f04). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/controllers/dacpacDialogWebviewController.ts 78.57% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##             release/1.37   #20544   +/-   ##
===============================================
  Coverage                ?   57.67%           
===============================================
  Files                   ?      207           
  Lines                   ?    18948           
  Branches                ?     1183           
===============================================
  Hits                    ?    10929           
  Misses                  ?     8019           
  Partials                ?        0           
Files with missing lines Coverage Δ
src/controllers/dacpacDialogWebviewController.ts 89.93% <78.57%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dacpac Dialog needs telemetry/logging and survey prompt upon completion

3 participants