Skip to content

Adding nps and logging for dacpac and bacpac operations#20540

Merged
allancascante merged 2 commits intomainfrom
dev/allancascante/logging_telemetry_nps
Nov 12, 2025
Merged

Adding nps and logging for dacpac and bacpac operations#20540
allancascante merged 2 commits intomainfrom
dev/allancascante/logging_telemetry_nps

Conversation

@allancascante
Copy link
Copy Markdown
Contributor

@allancascante allancascante commented Nov 11, 2025

Description

Added telemetry and logging so that we can understand usage and failures in the dacpac dialog operations
Added a survey prompt trigger when users complete a publish/extract/import/export operation in the dacpac dialog.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 11, 2025

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 59.64% 59.67% ⚪ 0.00%
VSIX Size 5238 KB 5238 KB ⚪ 0 KB ( 0% )
Webview Bundle Size 5256 KB 5256 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.67%. Comparing base (1bc962c) to head (84e8316).
⚠️ Report is 692 commits behind head on main.

Files with missing lines Patch % Lines
src/controllers/dacpacDialogWebviewController.ts 78.57% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20540      +/-   ##
==========================================
+ Coverage   57.63%   57.67%   +0.03%     
==========================================
  Files         207      207              
  Lines       18921    18948      +27     
  Branches     1181     1183       +2     
==========================================
+ Hits        10906    10929      +23     
- Misses       8015     8019       +4     
Files with missing lines Coverage Δ
src/controllers/dacpacDialogWebviewController.ts 89.93% <78.57%> (-1.10%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/controllers/dacpacDialogWebviewController.ts Outdated
Comment thread src/controllers/dacpacDialogWebviewController.ts Outdated
Comment thread src/controllers/dacpacDialogWebviewController.ts Outdated
@allancascante allancascante merged commit cd02a0a into main Nov 12, 2025
2 of 3 checks passed
@allancascante allancascante deleted the dev/allancascante/logging_telemetry_nps branch November 12, 2025 00:40
kburtram pushed a commit that referenced this pull request Nov 12, 2025
* Follow up fixes after PR merge (#20519)

- Added when clause to DacPac commands in command palette to respect mssql.experimentalFeaturesEnabled flag #20512 
- Renamed DacPac commands to grouped naming convention (mssql.dacpacDialog.*) #20513 
- Added OS-specific localization for "Reveal in Explorer" button (Windows/macOS/Linux) #20511 
- Extracted Data-tier Applications documentation URL to constants
- Updated application version validation to accept 2-part versions (e.g., 1.0) #20514 
- Changed validation state to display warnings

* Adding nps and logging for dacpac and bacpac operations (#20540)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants