Skip to content

[Port] Follow up fixes after PR merge (#20519)#20524

Merged
kburtram merged 1 commit intorelease/1.37from
port/allancascante/dacpacFixes
Nov 10, 2025
Merged

[Port] Follow up fixes after PR merge (#20519)#20524
kburtram merged 1 commit intorelease/1.37from
port/allancascante/dacpacFixes

Conversation

@allancascante
Copy link
Copy Markdown
Contributor

Description

Fixes: #20511 #20512 #20513 #20514
Original PR: #20519

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

- Added when clause to DacPac commands in command palette to respect mssql.experimentalFeaturesEnabled flag #20512 
- Renamed DacPac commands to grouped naming convention (mssql.dacpacDialog.*) #20513 
- Added OS-specific localization for "Reveal in Explorer" button (Windows/macOS/Linux) #20511 
- Extracted Data-tier Applications documentation URL to constants
- Updated application version validation to accept 2-part versions (e.g., 1.0) #20514 
- Changed validation state to display warnings
@kburtram kburtram merged commit af728fe into release/1.37 Nov 10, 2025
2 of 3 checks passed
@kburtram kburtram deleted the port/allancascante/dacpacFixes branch November 10, 2025 23:38
@github-actions
Copy link
Copy Markdown

PR Changes

Category Target Branch PR Branch Difference
Code Coverage 59.63% 59.65% ⚪ 0.00%
VSIX Size 5236 KB 5237 KB ⚪ 1 KB ( 0% )
Webview Bundle Size 5252 KB 5256 KB ⚪ 4 KB ( 0% )

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.64%. Comparing base (ef4ff0c) to head (cbd2192).
⚠️ Report is 1 commits behind head on release/1.37.

Files with missing lines Patch % Lines
src/controllers/dacpacDialogWebviewController.ts 66.66% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/1.37   #20524      +/-   ##
================================================
+ Coverage         57.60%   57.64%   +0.03%     
================================================
  Files               207      207              
  Lines             18827    18839      +12     
  Branches           1178     1178              
================================================
+ Hits              10846    10860      +14     
+ Misses             7981     7979       -2     
Files with missing lines Coverage Δ
src/constants/constants.ts 100.00% <100.00%> (ø)
src/constants/locConstants.ts 83.29% <100.00%> (+0.03%) ⬆️
src/controllers/dacpacDialogWebviewController.ts 91.02% <66.66%> (-0.38%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants