Follow up fixes after PR merge#20519
Merged
allancascante merged 6 commits intomainfrom Nov 10, 2025
Merged
Conversation
allancascante
requested review from
Benjin,
aasimkhan30,
caohai,
kburtram,
laurenastrid1,
lewis-sanchez,
manujoseph85 and
ssreerama
as code owners
PR Changes
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20519 +/- ##
==========================================
+ Coverage 57.60% 57.64% +0.03%
==========================================
Files 207 207
Lines 18827 18839 +12
Branches 1178 1178
==========================================
+ Hits 10846 10860 +14
+ Misses 7981 7979 -2
🚀 New features to boost your workflow:
|
allancascante
changed the title
This was
linked to
issues
Nov 10, 2025
Benjin
approved these changes
Nov 10, 2025
allancascante
deleted the
dev/allancascante/dacpac_dialog_fix_conditional_commands
branch
allancascante
added a commit
that referenced
this pull request
Nov 10, 2025
- Added when clause to DacPac commands in command palette to respect mssql.experimentalFeaturesEnabled flag #20512 - Renamed DacPac commands to grouped naming convention (mssql.dacpacDialog.*) #20513 - Added OS-specific localization for "Reveal in Explorer" button (Windows/macOS/Linux) #20511 - Extracted Data-tier Applications documentation URL to constants - Updated application version validation to accept 2-part versions (e.g., 1.0) #20514 - Changed validation state to display warnings
5 tasks
kburtram
pushed a commit
that referenced
this pull request
Nov 10, 2025
- Added when clause to DacPac commands in command palette to respect mssql.experimentalFeaturesEnabled flag #20512 - Renamed DacPac commands to grouped naming convention (mssql.dacpacDialog.*) #20513 - Added OS-specific localization for "Reveal in Explorer" button (Windows/macOS/Linux) #20511 - Extracted Data-tier Applications documentation URL to constants - Updated application version validation to accept 2-part versions (e.g., 1.0) #20514 - Changed validation state to display warnings
allancascante
added a commit
that referenced
this pull request
Nov 12, 2025
- Added when clause to DacPac commands in command palette to respect mssql.experimentalFeaturesEnabled flag #20512 - Renamed DacPac commands to grouped naming convention (mssql.dacpacDialog.*) #20513 - Added OS-specific localization for "Reveal in Explorer" button (Windows/macOS/Linux) #20511 - Extracted Data-tier Applications documentation URL to constants - Updated application version validation to accept 2-part versions (e.g., 1.0) #20514 - Changed validation state to display warnings
kburtram
pushed a commit
that referenced
this pull request
Nov 12, 2025
* Follow up fixes after PR merge (#20519) - Added when clause to DacPac commands in command palette to respect mssql.experimentalFeaturesEnabled flag #20512 - Renamed DacPac commands to grouped naming convention (mssql.dacpacDialog.*) #20513 - Added OS-specific localization for "Reveal in Explorer" button (Windows/macOS/Linux) #20511 - Extracted Data-tier Applications documentation URL to constants - Updated application version validation to accept 2-part versions (e.g., 1.0) #20514 - Changed validation state to display warnings * Adding nps and logging for dacpac and bacpac operations (#20540)
kburtram
pushed a commit
that referenced
this pull request
Nov 14, 2025
* Follow up fixes after PR merge (#20519) - Added when clause to DacPac commands in command palette to respect mssql.experimentalFeaturesEnabled flag #20512 - Renamed DacPac commands to grouped naming convention (mssql.dacpacDialog.*) #20513 - Added OS-specific localization for "Reveal in Explorer" button (Windows/macOS/Linux) #20511 - Extracted Data-tier Applications documentation URL to constants - Updated application version validation to accept 2-part versions (e.g., 1.0) #20514 - Changed validation state to display warnings * adding preview to the dacpac dialog labels (#20581) * adding preview to the dacpac dialog labels * adding preview to the dacpac dialog labels
kburtram
pushed a commit
that referenced
this pull request
Nov 17, 2025
#20604) * Follow up fixes after PR merge (#20519) - Added when clause to DacPac commands in command palette to respect mssql.experimentalFeaturesEnabled flag #20512 - Renamed DacPac commands to grouped naming convention (mssql.dacpacDialog.*) #20513 - Added OS-specific localization for "Reveal in Explorer" button (Windows/macOS/Linux) #20511 - Extracted Data-tier Applications documentation URL to constants - Updated application version validation to accept 2-part versions (e.g., 1.0) #20514 - Changed validation state to display warnings * Adding fabric warning for dacpac dialog and small fix to styles (#20599) * adding fabric warning for dacpac dialog and small fix to styles * lint fixes * localization changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses:
#20511 - Use platform-specific text for "Reveal in " to match VS Code
#20512 - DacPac commands showing when experimental features disabled
#20513 - Rename dacpac dialog commands so they're grouped as a feature
#20514 - Dacpac Dialog logic blocks valid 1.1 version. Added other small fixes requested, as follow up of previous PR.
Changes:
1.1version #20514Code Changes Checklist
npm run test)Reviewers: Please read our reviewer guidelines