Skip to content

[RFC] Implement ShowTextDocumentRequest#490

Closed
darkbasic wants to merge 9 commits intomicrosoft:masterfrom
darkbasic:show-text-document-request
Closed

[RFC] Implement ShowTextDocumentRequest#490
darkbasic wants to merge 9 commits intomicrosoft:masterfrom
darkbasic:show-text-document-request

Conversation

@darkbasic
Copy link

@msftclas
Copy link

msftclas commented Apr 26, 2019

CLA assistant check
All CLA requirements met.

@dbaeumer
Copy link
Member

dbaeumer commented May 7, 2019

@darkbasic I would like to ask you to provide this as a protocol extension like described in https://github.com/microsoft/language-server-protocol/blob/master/contributing.md. This has the advantage that we have separate files which eases the code review. We could then even have it in a next version of the LSP libraries.

You could take protocol/src/protocol.configuration.ts client/src/configuration.ts and server/src/configuration.ts as a blue print since it sends a request from the server to the client as well.

@darkbasic
Copy link
Author

@dbaeumer thanks, it's under its own standalone proposal now.

Copy link
Contributor

@rcjsuen rcjsuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darkbasic I still don't understand what a server is supposed to do if the client fails to open the editor. Could you please explain what the use case is here?

@darkbasic
Copy link
Author

Client capabilities are now declared.
@rcjsuen I thinked about it and there is nothing the server can do if the client fails to open the editor. In fact I decided to not return a boolean anymore: if there is an error it can still be catched thanks to the protocol capabilities.

@dbaeumer
Copy link
Member

@darkbasic I re-implemented this since a lot has changed since the creation of the PR. I will still mention you in the N&N since you are the original creator of the code.

@dbaeumer dbaeumer closed this Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants