Add generic capabilities type#459
Merged
dbaeumer merged 1 commit intomicrosoft:masterfrom Feb 19, 2019
johnwiseheart:jw/generic-capabilities
Merged
Add generic capabilities type#459dbaeumer merged 1 commit intomicrosoft:masterfrom johnwiseheart:jw/generic-capabilities
dbaeumer merged 1 commit intomicrosoft:masterfrom
johnwiseheart:jw/generic-capabilities
Conversation
Member
|
Actually that makes sense now that TS support default values for generics. |
Author
|
Hey @dbaeumer would you mind publishing a new version to npm? Would like to use this in https://www.npmjs.com/package/vscode-base-languageclient |
Member
|
I released new verion as next. However |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a variety of experimental capabilities that we add using the
ServerCapabilitiestype, but are unable to type them nicely becauseexperimentalis typed asany. By adding this generic, it would enable people to reuse this type, without having to hack around theany, without changing how any back-compatibility of existing code works (I think).Thoughts?