If a new constant is going to be added, please update the specification also.

@rcjsuen I believe the specification maps to the current release where as the changes in this PR map to the pre-release version.

@dbaeumer Is there any version of the specification where we should update the pre-release changes?

The changes look good to me. The contextSupport is new for 4.0, so no need to add an additional client capability.

@ramya-rao-a The current specification of the LSP is v3 but it is still receiving updates on a regular basis. In fact, CompletionTriggerKind did not originally exist in v3 but was only recently added in November.

In any case, I have opened microsoft/language-server-protocol#403 to update the protocol to include the new TriggerForIncompleteCompletions you added.

@ramya-rao-a in general the spec needs to be updated as well when we do something in code :-).

@rcjsuen thanks for updating the spec

@rcjsuen @dbaeumer Thanks, I'll keep that in mind for the next time.