Client does not declare that clientCapabilities.workspace.workspaceEdit.documentChanges is supported#307
Merged
dbaeumer merged 1 commit intomicrosoft:masterfrom Feb 9, 2018
Conversation
Since the vscode-languageclient package supports versioned edits in a WorkspaceEdit sent in a workspace/applyEdit request, it should be stated as such in the client's initialiation parameters. This will allow supporting language servers to get the right information from VS Code and to then send back versioned edits instead of regular edits without any versioning. Signed-off-by: Remy Suen <[email protected]>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/Microsoft/vscode-languageserver-node/blob/f4595fa4f3a52c9210792c7b412f9e2ee478cdd3/client/src/client.ts#L2945-L2955
As seen in the code above, we can see that
documentChangesare supported and are handled by the VS Code LSP client. However, this capability is not stated in the initialization parameters that the LSP client sends to a language server. It used to be sent but it was commented out and later removed. This is basically the same problem as #263 just for a different capability. This pull request adds the capability back to the initialization parameters and fixes #306.