Change TextDocument's getText to take an optional range#298
Merged
aeschli merged 1 commit intomicrosoft:masterfrom Jan 10, 2018
Merged
Change TextDocument's getText to take an optional range#298aeschli merged 1 commit intomicrosoft:masterfrom
aeschli merged 1 commit intomicrosoft:masterfrom
Conversation
object88
pushed a commit
to object88/vscode-languageserver-node
that referenced
this pull request
Dec 28, 2017
object88
pushed a commit
to object88/vscode-languageserver-node
that referenced
this pull request
Dec 28, 2017
Multi-root declared as ServerCapability (microsoft#298)
Member
|
@aeschli can you please review and follow up? |
TextDocument's getText() function has been changed to take an optional range in the form of getText(range?: Range). This allows clients to extract a substring within the document instead of the entire document. Ranges that start at a position smaller than the document will be adjusted to the beginning of the document. Likewise, ranges that end beyond the length of the document will be adjusted to end within the bounds of the document. Signed-off-by: Remy Suen <[email protected]>
Contributor
|
I'm fine with the change. What is to be fixed is the specification of special cases:
I'll add that. |
Contributor
Author
|
Thank you for taking the time to look at this, Martin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've changed
TextDocumentso that itsgetText()function is now agetText(range?: Range). This fixes #255 and allows a client to extract a substring from the document instead of the entire range. If any positions are detected to be outside the bounds of the document (an offset less than zero or an offset greater than the length of the document), they will be adjusted to accordingly to fit within the bounds of the document.