Skip to content

Cleanup "installServerIntoExtension" script#150

Merged
dbaeumer merged 2 commits intomicrosoft:masterfrom
Turbo87:fix-bin
Jan 31, 2017
Merged

Cleanup "installServerIntoExtension" script#150
dbaeumer merged 2 commits intomicrosoft:masterfrom
Turbo87:fix-bin

Conversation

@Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Jan 28, 2017

This PR removes an unused function from the script and adds a missing var keyword.

@msftclas
Copy link

msftclas commented Jan 28, 2017

Hi @Turbo87, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

1 similar comment
@msftclas
Copy link

msftclas commented Jan 28, 2017

Hi @Turbo87, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

@Turbo87
Copy link
Contributor Author

Turbo87 commented Jan 28, 2017

@msftclas CLA should be signed now

@msftgits
Copy link
Contributor

msftgits commented Jan 30, 2017

Hi, I am closing and re-opening this PR to bump the CLA bot. Sorry for the inconvenience!

@msftgits msftgits closed this Jan 30, 2017
@msftgits msftgits reopened this Jan 30, 2017
@msftclas
Copy link

msftclas commented Jan 30, 2017

Hi @Turbo87, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

1 similar comment
@msftclas
Copy link

msftclas commented Jan 30, 2017

Hi @Turbo87, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, MSBOT;

@Turbo87
Copy link
Contributor Author

Turbo87 commented Jan 30, 2017

🎉

@dbaeumer
Copy link
Member

dbaeumer commented Jan 31, 2017

@Turbo87 Thanks!

@dbaeumer dbaeumer merged commit f80a25f into microsoft:master Jan 31, 2017
@Turbo87 Turbo87 deleted the fix-bin branch January 31, 2017 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Turbo87 @msftclas @msftgits @dbaeumer