Don't crash when unregistering a feature that doesn't exist#1460
Merged
dbaeumer merged 1 commit intomicrosoft:mainfrom Apr 15, 2024
Merged
Don't crash when unregistering a feature that doesn't exist#1460dbaeumer merged 1 commit intomicrosoft:mainfrom
dbaeumer merged 1 commit intomicrosoft:mainfrom
Conversation
Note: all other features follow the same practice in their `unregister()` methods -- if the features doesn't exist, do nothing and don't throw errors.
Member
|
Makes sense to make this consistent. |
dbaeumer
approved these changes
Apr 15, 2024
jrieken
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: all other features follow the same practice in their
unregister()methods -- if the features doesn't exist, do nothing and don't throw errors.