Round progress percentage according to the spec #1413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@microsoft-github-policy-service agree |
dbaeumer
requested changes
Jan 30, 2024
Member
dbaeumer
left a comment
dbaeumer
left a comment
There was a problem hiding this comment.
See my comments about the tests.
Member
|
and thanks a lot for the PR. |
w0rm
force-pushed
the
round-progress-percentage
branch
from
ab0ffad to
cd14443
Compare
Contributor
Author
|
@dbaeumer thanks for the review, I've created a separate test and added the comment. |
w0rm
force-pushed
the
round-progress-percentage
branch
from
cd14443 to
de7873f
Compare
dbaeumer
approved these changes
Jan 31, 2024
aeschli
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1412