Support WorkspaceEditMetadata in workspace/applyEdit
#1390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dbaeumer, I'm guessing that you missed this when you got back from vacation. |
dbaeumer
reviewed
Jan 11, 2024
Member
dbaeumer
left a comment
dbaeumer
left a comment
There was a problem hiding this comment.
We should also add a capability to WorkspaceEditClientCapabilities (e.g. metaDataSupport).
We would also need a PR against the 3.18 spec here:
dbaeumer
approved these changes
Jan 17, 2024
mjbvz
approved these changes
Jan 17, 2024
Contributor
Author
|
@dbaeumer, thanks for taking this change. Any guess as to when your next release will be available? |
Member
|
I want to get the snippet support in as well before having a new release. This however requires the new VS Code release that is due this week. So a new LSP release will not arrive before next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix microsoft/pylance-release#5217 (comment) in Pylance, I'd need the
Workspace.applyEditcall inhandleApplyWorkspaceEditto pass{ isRefactoring: true }as the second parameter.Is it reasonable to add
WorkspaceEditMetadatatoworkspace/applyEdit, soisRefactoringcan be sent optionally via LSP?