@dbaeumer while working on this I realized that it would be quite convenient to use StringValues in TextEdits to achieve this instead of introducing a new SnippetTextEdit type. That is, changing the type of textEdit.newText to string | StringValue.

The problem with that is that StringValue is still part of the the proposed inline completion feature, and I'm not sure about adding the dependence between the features.

@MariaSolOs I think we should stay away from changing TextEdit. TextEdit is used in many places and not all of them might support snippets. And it will be a big breaking change if clients use TextEdits as results with structural typing. The TS compiler will then emit errors since a StringValue will not be assignable to a string.

As always great work.

@dbaeumer I've addressed your comments. Please let me know if I'm missing anything else :)

@MariaSolOs will you provide a PR for the spec as well?

@MariaSolOs will you provide a PR for the spec as well?

Yep, working on it.

EDIT: I will wait for the resolution of #1343 (comment) before updating the specs.