Skip to content

Spec says WorkspaceSymbolParams.query should be non-empty but client sends empty strings #458

@DanTup

Description

@DanTup

For workspace/symbol the spec defines WorkspaceSymbolParams as:

/**
 * The parameters of a Workspace Symbol Request.
 */
interface WorkspaceSymbolParams {
	/**
	 * A non-empty query string
	 */
	query: string;
}

The definition doesn't permit null or undefined and the comment says it's non-empty, however the language client sends requests with empty strings for the query when opening the workspace symbol list:

screenshot 2019-02-11 at 1 59 06 pm

I'm raising this here since it seems to violate the spec, however I wonder if the spec should permit either null, undefined or "" since right now it seems like you couldn't list all.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions