Fix padding and margin on jupyter alert styles #10034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
changed the title
Contributor
Author
|
Before this change, it looked like:
|
Contributor
Author
|
And this is how the same boxes appear in Jupyter:
|
Codecov Report
@@ Coverage Diff @@
## main #10034 +/- ##
======================================
Coverage 63% 63%
======================================
Files 215 215
Lines 10122 10122
Branches 1612 1612
======================================
+ Hits 6473 6477 +4
+ Misses 3131 3124 -7
- Partials 518 521 +3
|
rchiodo
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have tested this more in #10021; the styles were better than nothing, but quite ugly.
Here's how this looks now:
Has sufficient logging.Has telemetry for feature-requests.Unit tests & system/integration tests are added/updated.Test plan is updated as appropriate.package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).