Skip to content

Add alert box styling for notebooks #10021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rchiodo merged 1 commit into from
May 13, 2022
Merged

Add alert box styling for notebooks #10021

rchiodo merged 1 commit into from
May 13, 2022

Conversation

@eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented May 13, 2022 •
edited
Loading

These style names are inherited from bootstrap, but seem to be the defacto standard for jupyter notebooks.
See https://nbviewer.org/github/ipython/ipython-in-depth/blob/master/examples/Notebook/Notebook%20Basics.ipynb for an example by ipython of these styles being used.
Note there is no appropriate color to uses for success.

Partially addresses #8399

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for feature-requests.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@eric-wieser eric-wieser requested a review from a team as a code owner May 13, 2022 09:46
@eric-wieser
Add alert box styling for notebooks
707071b 
These style names are inherited from bootstrap, but seem to be the defacto standard for jupyter notebooks.
Note there is no appropriate color to uses for `success`.
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2022

Codecov Report

Merging #10021 (707071b) into main (f35e44a) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #10021   +/-   ##
======================================
- Coverage     63%      63%   -1%     
======================================
  Files        211      211           
  Lines      10097    10097           
  Branches    1611     1611           
======================================
- Hits        6456     6452    -4     
+ Misses      3125     3124    -1     
- Partials     516      521    +5
Impacted Files Coverage Δ
src/platform/errors/errorHandler.ts 62% <0%> (-1%) ⬇️
...ommon/process/environmentActivationService.node.ts 69% <0%> (-1%) ⬇️
...rc/platform/common/dataScienceSurveyBanner.node.ts 70% <0%> (ø)

@rchiodo rchiodo merged commit 9880bbc into microsoft:main May 13, 2022
@eric-wieser eric-wieser mentioned this pull request May 15, 2022
Merged
9 tasks
@eric-wieser eric-wieser mentioned this pull request Jun 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rchiodo rchiodo rchiodo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eric-wieser @codecov-commenter @rchiodo