Use 'if' to create completions#27
Use 'if' to create completions#27aeschli merged 6 commits intomicrosoft:masterfrom Levertion:if-completions
Conversation
|
Cool! |
|
I think that should already be what is happening, although I haven't validated it. I was more worried that I was breaking some invariants of |
|
@Levertion works correct for me. Thanks for enhancement. |
|
@Levertion The test is still failing... |
|
Sorry, I've been busy with other stuff. My latest commit was to clear my working tree before I opened #30. |
|
OK - I've written enough tests to convince myself that the behaviour is correct, although I'm unsure about the formatting. Should we format automatically somehow - clearly the style is to use My personal preference is |
|
just use the built-in TypeScript formatter with default settings |
|
I have tried that, using both format document and format selection after commenting out my entire |
|
Yes, that's fine. The formatter preserves new lines, that's why the changes are so small. |
|
Well in that case I think this PR is finished, unless there are any other changes you want me to make |
|
It's great, thanks a lot @Levertion ! |
I'm not certain that this implementation is correct for the codebase, but it doesn't break any of the other tests (as added in #24) and passes my new test. @Fer0x: if you could validate that this looks right too.
I've only added one test case, but want to check that this feature is desired before adding more tests.